Open
Conversation
kekulta
reviewed
Jul 29, 2024
Comment on lines
+1
to
+19
| public class Car { | ||
| String name; | ||
| int speed; | ||
|
|
||
| void setCarName(String name) { | ||
| this.name = name; | ||
| } | ||
|
|
||
| void setSpeed(int speed) { | ||
| this.speed = speed; | ||
| } | ||
|
|
||
| String getName() { | ||
| return name; | ||
| } | ||
|
|
||
| double calcKmForDay() { | ||
| return speed * 24; | ||
| } |
There was a problem hiding this comment.
Здорово, что вынес отдельно в класс логику.
Comment on lines
+22
to
+24
| } else { | ||
| throw new Exception(); | ||
| } |
There was a problem hiding this comment.
try/catch лучше использовать только когда что-то действительно идёт не так. В данном случае лучше использовать if/else/
Comment on lines
+25
to
+30
| } catch (InputMismatchException e) { | ||
| System.out.println("Ошибка: это не число"); | ||
| scan.next(); | ||
| } catch (Exception e) { | ||
| System.out.println("Ошибка: введите корректное число от 0 до 250"); | ||
| } |
There was a problem hiding this comment.
Здорово, что обрабатываешь ошибки, но здесь можно было сделать проще использую метод сканнера hasNextInt()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.