Skip to content

new target: Elixir HTTPoison#235

Closed
danirukun wants to merge 1 commit intoKong:masterfrom
danirukun:feature/add-elixir-httpoison-target
Closed

new target: Elixir HTTPoison#235
danirukun wants to merge 1 commit intoKong:masterfrom
danirukun:feature/add-elixir-httpoison-target

Conversation

@danirukun
Copy link
Copy Markdown

@danirukun danirukun commented Nov 24, 2021

This PR implement a target for the Elixir HTTPoison HTTP client.

Closes #234

Example generated snippet:

HTTPoison.request(:post, "http://mockbin.com/har", "foo=bar&hello=world", [{"content-type", "application/x-www-form-urlencoded"}])

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Nov 24, 2021 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@danirukun danirukun changed the title Implement Elixir HTTPoison target feat: Implement Elixir HTTPoison target Nov 26, 2021
@danirukun
Copy link
Copy Markdown
Author

danirukun commented Nov 26, 2021

Signed and CI passes, @reynolek please review 🙂

@danirukun
Copy link
Copy Markdown
Author

danirukun commented Jan 4, 2022

@erunion maybe you can review? Thanks.

erunion
erunion approved these changes Jan 4, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@erunion erunion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any Elixir experience, and can't run these snippets locally to ensure they work, but aside from a few very minor comments everything here looks ok to me.

ilias-t
ilias-t reviewed Jan 4, 2022
View reviewed changes
ilias-t
ilias-t reviewed Jan 5, 2022
View reviewed changes
@danirukun
Copy link
Copy Markdown
Author

danirukun commented Jan 5, 2022

Btw just Fyi I have tested every snippet manually using an Elixir Livebook, to verify that they are actually valid.

@danirukun danirukun force-pushed the feature/add-elixir-httpoison-target branch from ec590a8 to 59c3205 Compare January 6, 2022 00:13
@dimitropoulos dimitropoulos added the improvement improvement label Jul 13, 2022
@dimitropoulos dimitropoulos changed the title feat: Implement Elixir HTTPoison target new target: Elixir HTTPoison Jul 13, 2022
@dimitropoulos dimitropoulos added new target new target implementation and removed improvement improvement labels Jul 13, 2022
@filfreire
Copy link
Copy Markdown
Contributor

filfreire commented Jul 12, 2024

Closing, uses old way of adding a target.

@filfreire filfreire closed this Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@ilias-t ilias-t ilias-t left review comments

@erunion erunion erunion approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

new target new target implementation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Elixir

6 participants

@danirukun @CLAassistant @filfreire @erunion @ilias-t @dimitropoulos