Skip to content

better error message when schema ids are none #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msokoloff1 merged 2 commits into from
Oct 19, 2021
Merged

better error message when schema ids are none #315

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32bdae6
better error message
Oct 19, 2021
703cf81
update error message
Oct 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions labelbox/data/ontology.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ def get_feature_schema_lookup(

def flatten_classification(classifications):
for classification in classifications:
if classification.feature_schema_id is None:
raise ValueError(
f"feature_schema_id cannot be None for classification `{classification.name}`."
)
if isinstance(classification, ontology.Classification):
classification_lookup[
classification.
Expand All @@ -28,6 +32,9 @@ def flatten_classification(classifications):
flatten_classification(classification.options)

for tool in ontology_builder.tools:
if tool.feature_schema_id is None:
raise ValueError(
f"feature_schema_id cannot be None for tool `{tool.name}`.")
tool_lookup[tool.name] = tool.feature_schema_id
flatten_classification(tool.classifications)
flatten_classification(ontology_builder.classifications)
Expand Down