Skip to content

remove annotation groups#318

Merged
msokoloff1 merged 2 commits intodevelopfrom
ms/rename-annotation-groups
Oct 21, 2021
Merged

remove annotation groups#318
msokoloff1 merged 2 commits intodevelopfrom
ms/rename-annotation-groups

Conversation

@msokoloff1
Copy link
Copy Markdown
Contributor

@msokoloff1 msokoloff1 commented Oct 20, 2021 •
edited
Loading

  • Rename AnnotationGroup to ModelRunDataRows
  • I made these changes backwards compatible and added a deprecation warning.

@review-notebook-app
Copy link
Copy Markdown

review-notebook-app bot commented Oct 20, 2021

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

tomislav-peharda
tomislav-peharda approved these changes Oct 21, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@tomislav-peharda tomislav-peharda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally a name everyone agrees with.

@msokoloff1 msokoloff1 merged commit 4c54ed6 into develop Oct 21, 2021
@msokoloff1 msokoloff1 deleted the ms/rename-annotation-groups branch October 21, 2021 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gdj0nes gdj0nes Awaiting requested review from gdj0nes

@GrantEating GrantEating Awaiting requested review from GrantEating

1 more reviewer

@tomislav-peharda tomislav-peharda tomislav-peharda approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@msokoloff1 @tomislav-peharda