Skip to content

add federation queue state to get_federated_instances api#4104

Merged
dessalines merged 6 commits intomainfrom
federate-state-api
Nov 6, 2023
Merged

add federation queue state to get_federated_instances api#4104
dessalines merged 6 commits intomainfrom
federate-state-api

Conversation

@phiresky
Copy link
Copy Markdown
Collaborator

@phiresky phiresky commented Oct 24, 2023

  • Move FederationQueueState struct from lemmy_federate to lemmy_db_schema crate
  • Make ActivityId a newtype(i64)
  • Add ReadableFederationState to lemmy_api_common that's a bit more readable
  • Add a .federation_state property to the api response of each of allow/block/linked list of the /get_federated_instances response.

This change should be backwards compatible, it just adds new info to an endpoint.

Comment thread crates/api_common/src/site.rs Outdated
Comment thread crates/api_common/src/site.rs Outdated
Comment thread crates/db_schema/src/impls/federation_queue_state.rs Outdated
@phiresky
Copy link
Copy Markdown
Collaborator Author

Looks like I'll need to add a lemmy_utils+chrono dependency to lemmy_api_common with default feature set. If restructuring the files would be better I'd appreciate pointers.

@Nutomic
Copy link
Copy Markdown
Member

Nutomic commented Oct 25, 2023

lemmy_api_common makes the api available to other Rust projects like the instance crawler, so it should be as lightweight as possible. It already has chrono as transitive dependency with default feature from lemmy_db_schema so thats no problem (cargo tree -i chrono -p lemmy_api_common). But adding lemmy_utils is definitely a no because that means pulling in all of actix-web, diesel and more. I also dont see where thats needed, if necessary you can generally mark code as #[cfg(feature = "full")] so it will be ignored with default feature.

@phiresky
Copy link
Copy Markdown
Collaborator Author

phiresky commented Nov 2, 2023

I've cleaned it up, should be ready for review/merge @Nutomic @dessalines . It now needs a small DB migration

@dessalines dessalines merged commit b9b65c9 into main Nov 6, 2023
dullbananas pushed a commit to dullbananas/lemmy that referenced this pull request Nov 7, 2023
* Also order reports by oldest first (ref LemmyNet#4123) (LemmyNet#4129)

* Support signed fetch for federation (fixes LemmyNet#868) (LemmyNet#4125)

* Support signed fetch for federation (fixes LemmyNet#868)

* taplo

* add federation queue state to get_federated_instances api (LemmyNet#4104)

* add federation queue state to get_federated_instances api

* feature gate

* move retry sleep function

* move stuff around

* Add UI setting for collapsing bot comments. Fixes LemmyNet#3838 (LemmyNet#4098)

* Add UI setting for collapsing bot comments. Fixes LemmyNet#3838

* Fixing clippy check.

* Only keep sent and received activities for 7 days (fixes LemmyNet#4113, fixes LemmyNet#4110) (LemmyNet#4131)

* Only check auth secure on release mode. (LemmyNet#4127)

* Only check auth secure on release mode.

* Fixing wrong js-client.

* Adding is_debug_mode var.

* Fixing the desktop image on the README. (LemmyNet#4135)

* Delete dupes and add possibly missing unique constraint on person_aggregates.

* Fixing clippy lints.

---------

Co-authored-by: Nutomic <[email protected]>
Co-authored-by: phiresky <[email protected]>
dessalines added a commit that referenced this pull request Nov 13, 2023
* post_saved

* fmt

* remove unique and not null

* put person_id first in primary key and remove index

* use post_saved.find

* change captcha_answer

* remove removal of not null

* comment_aggregates

* comment_like

* comment_saved

* aggregates

* remove "\"

* deduplicate site_aggregates

* person_post_aggregates

* community_moderator

* community_block

* community_person_ban

* custom_emoji_keyword

* federation allow/block list

* federation_queue_state

* instance_block

* local_site_rate_limit, local_user_language, login_token

* person_ban, person_block, person_follower, post_like, post_read, received_activity

* community_follower, community_language, site_language

* fmt

* image_upload

* remove unused newtypes

* remove more indexes

* use .find

* merge

* fix site_aggregates_site function

* fmt

* Primary keys dess (#17)

* Also order reports by oldest first (ref #4123) (#4129)

* Support signed fetch for federation (fixes #868) (#4125)

* Support signed fetch for federation (fixes #868)

* taplo

* add federation queue state to get_federated_instances api (#4104)

* add federation queue state to get_federated_instances api

* feature gate

* move retry sleep function

* move stuff around

* Add UI setting for collapsing bot comments. Fixes #3838 (#4098)

* Add UI setting for collapsing bot comments. Fixes #3838

* Fixing clippy check.

* Only keep sent and received activities for 7 days (fixes #4113, fixes #4110) (#4131)

* Only check auth secure on release mode. (#4127)

* Only check auth secure on release mode.

* Fixing wrong js-client.

* Adding is_debug_mode var.

* Fixing the desktop image on the README. (#4135)

* Delete dupes and add possibly missing unique constraint on person_aggregates.

* Fixing clippy lints.

---------

Co-authored-by: Nutomic <[email protected]>
Co-authored-by: phiresky <[email protected]>

* fmt

* Update community_block.rs

* Update instance_block.rs

* Update person_block.rs

* Update person_block.rs

---------

Co-authored-by: Dessalines <[email protected]>
Co-authored-by: Nutomic <[email protected]>
Co-authored-by: phiresky <[email protected]>
@Nothing4You Nothing4You deleted the federate-state-api branch September 11, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants