Skip to content

Assignment 2#2

Open
Linz498 wants to merge 3 commits intomainfrom
assignment-2
Open

Assignment 2#2
Linz498 wants to merge 3 commits intomainfrom
assignment-2

Conversation

@Linz498
Copy link
Copy Markdown
Owner

@Linz498 Linz498 commented Aug 30, 2025

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

Adding code that retrieves and appends files into a larger data set, calculates functions on the data in the files, and raises a flag if the calculation for the mean in one of the files is 0.

What did you learn from the changes you have made?

I learned to use the Numpy library including its arrays to calculate functions on the data sets.

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

I ended up using defined strings instead of boolean values for the check zero question as for some reason they boolean values did not seem to show up when I ran my code, but it worked once I assigned my own strings to denote the boolean values.

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

I am unsure if I completed the first portion correctly. I don't know if it is supposed to in big chunks or a row. I was also struggling to understand the check zeros and how to make the True/False values from it return when run so I ended up using strings instead.

How were these changes tested?

The changes were tested using the code testing sections in the document and cross referencing outputs with the expected output based on the question.

A reference to a related issue in your repository (if applicable)

Checklist

  • I can confirm that my changes are working as intended

Copy link
Copy Markdown

@xindizhang xindizhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes Requested

Great work!

Part 1: You're currently printing all files, but the question asks you to print only the first file.

Part 3: The detect_problems function should return a Boolean value (True or False).

Please adjust your submission accordingly.

@Linz498
Copy link
Copy Markdown
Owner Author

Linz498 commented Sep 6, 2025

Python Assignment 2 submission has been adjusted accordingly for Part 1 and Part 3 as per feedback. @xindizhang

Copy link
Copy Markdown

@xindizhang xindizhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! No further changes needed.
Just one minor note: it’s good style to keep related logic—like your for loop to print each line—inside the with block where the file is opened and read.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants