Open
Conversation
xindizhang
suggested changes
Sep 4, 2025
xindizhang
left a comment
There was a problem hiding this comment.
Changes Requested
Great work!
Part 1: You're currently printing all files, but the question asks you to print only the first file.
Part 3: The detect_problems function should return a Boolean value (True or False).
Please adjust your submission accordingly.
Owner
Author
|
Python Assignment 2 submission has been adjusted accordingly for Part 1 and Part 3 as per feedback. @xindizhang |
xindizhang
approved these changes
Sep 7, 2025
xindizhang
left a comment
There was a problem hiding this comment.
Great work! No further changes needed.
Just one minor note: it’s good style to keep related logic—like your for loop to print each line—inside the with block where the file is opened and read.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Adding code that retrieves and appends files into a larger data set, calculates functions on the data in the files, and raises a flag if the calculation for the mean in one of the files is 0.
What did you learn from the changes you have made?
I learned to use the Numpy library including its arrays to calculate functions on the data sets.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
I ended up using defined strings instead of boolean values for the check zero question as for some reason they boolean values did not seem to show up when I ran my code, but it worked once I assigned my own strings to denote the boolean values.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
I am unsure if I completed the first portion correctly. I don't know if it is supposed to in big chunks or a row. I was also struggling to understand the check zeros and how to make the True/False values from it return when run so I ended up using strings instead.
How were these changes tested?
The changes were tested using the code testing sections in the document and cross referencing outputs with the expected output based on the question.
A reference to a related issue in your repository (if applicable)
Checklist