Conversation
e5f8fdf to
f0371ed
Compare
nalanj
reviewed
Mar 31, 2026
nalanj
approved these changes
Mar 31, 2026
|
@notnmeyer either way - I'm fine if it just goes to current directory, but also I'd be fine if we just documented how to install it from the download. |
77a66f4 to
0d6416e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
install script for the good ole cure-pipe-bash method. uses the utility functions from https://github.com/client9/shlib which have proven excellent in the past. additionally, owes lineage to the defunct https://github.com/goreleaser/godownloader project too. the bones here are used in many goreleaser powered.
i think between the command in the readme and verifying the checksums of the downloads, this capture most of the best practices to make these sorts of scripts safe.
note that if you want to test out the commands in the readme you'll need to swap in this branch in the url. the install script does not yet exist on
main.