Conversation
Owner
Author
|
Assignment 1 was completed last week, but the pull request was done to the DSI main, and did not go through, this is an attempt to merge into MK-DSI main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Added 2 blocks of code to assess whatever the 2 words are anagrams or not, in first case not case sensitive, in the second - case sensitive.
What did you learn from the changes you have made?
How to write more complex code! Exciting. IF/ELSE functions and how to transition string to list, how to use methods with strings and lists.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Yes, especially in the case of the Part 2. Capital letters are sorted separately, some considerations and additional manipulations can be tested.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
One, I struggled for 5-10 minutes with .UPPER or .LOWER methods and immutability of the string format. Logic of method was a bit confusing, but I have quickly figured that out.
How were these changes tested?
I worked in my VS code, broke the code into simpler tasks and bits until all individual commands worked, then pulled them together into one code.
A reference to a related issue in your repository (if applicable)
Not very clear question, N/A
Checklist