Fixed #910 Search results just disappear when switching to other app and back#947
Open
buddax2 wants to merge 1 commit intoMacPass:masterfrom
Open
Fixed #910 Search results just disappear when switching to other app and back#947buddax2 wants to merge 1 commit intoMacPass:masterfrom
buddax2 wants to merge 1 commit intoMacPass:masterfrom
Conversation
…er app and back
mstarke
reviewed
Jun 28, 2019
Member
mstarke
left a comment
There was a problem hiding this comment.
I'm not sure this is the right way to fix this since it's raising other issues
| } | ||
| MPDocument *document = self.windowController.document; | ||
| document.selectedGroups = self.currentTargetGroups; | ||
| if (document.selectedGroups != self.currentTargetGroups) { |
Member
There was a problem hiding this comment.
This fixed the issue of an unexpected exit of search but raises another. When a user clicks inside the outline view and selects the currently selected group this wont show up in the inspector. Instead another group needs to be selected and the the old on should be re-selected. It might be usefull to go a special route just if search is active
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Default behavior for the outline view is to set the current target groups to the active document. But this action resets search results and this behavior is OK I suppose. So I assume there is no needs to update current target groups in the document if it didn't change.