Open
Conversation
mstarke
reviewed
Sep 1, 2019
Member
mstarke
left a comment
There was a problem hiding this comment.
Thank you for the PR but this is currently not mergeable for 0.7.x since the UserNotification framework requires 10.14 and the deploy target for MacPass ist still 10.10. This will be raised with 0.8 to 10.12 or even higher but the 0.7.x branch should stay compatible with 10.10. which requires to stick with the deprecated NSUserNotification. Another note - I'm hesitant to introduce .swift code since it requires to bundle the swift runtime AFAIK and I also do not have no plans to fully convert MacPass to swift any time soon. This might sound foolish but for now I'm more productive with Obj-C and keeping the code base manageable for me is of high value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a notifications helper class, should help with implementing issue #951