Skip to content

Update changes#1

Open
Mahbubk8 wants to merge 2 commits intomainfrom
assignment-1
Open

Update changes#1
Mahbubk8 wants to merge 2 commits intomainfrom
assignment-1

Conversation

@Mahbubk8
Copy link
Copy Markdown
Owner

@Mahbubk8 Mahbubk8 commented Dec 7, 2024

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

Proper branching of python assigment-1

What did you learn from the changes you have made?

Correctly branching in Git/shell

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

Nothing

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

New learning, and to read the instruction first.

How were these changes tested?

In python with different arguments

A reference to a related issue in your repository (if applicable)

N/A

Checklist

  • [X ] I can confirm that my changes are working as intended

@pedram-aliniaye-asli
Copy link
Copy Markdown

you did a great job here!
Please go ahead and close this pull request now. Thanks!

" ax = 1 # this specifies that the operation should be done for each row (patient)\n",
"\n",
" # implement the specific operation based on the 'operation' argument\n",
" if operation == 'mean':\n",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic to compute mean is missing. e.g. value = data.mean(axis=ax)

" elif operation == 'max':\n",
" # YOUR CODE HERE: calculate the maximum number of flare-ups experienced by each patient\n",
"\n",
" elif operation == 'min':\n",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic to compute min is missing.

" if operation == 'mean':\n",
" # YOUR CODE HERE: calculate the mean (average) number of flare-ups for each patient\n",
"\n",
" elif operation == 'max':\n",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic to compute max is missing.

"# Define your function `detect_problems` here\n",
"\n",
"def detect_problems(file_path):\n",
" #YOUR CODE HERE: use patient_summary() to get the means and check_zeros() to check for zeros in the means\n",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please complete this part.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Moniz, I didn't even submitted python assignment 2! Completed/pull requested python assignment 1. I'll submit python assignment-2 tonight. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants