chore: sync development to main#2664
Merged
maintainerr-automation[bot] merged 4 commits intomainfrom Apr 12, 2026
Merged
Conversation
4 tasks
* fix: remove SSRF sinks from API failure logging Replace axios.getUri() calls in external-api, plexApi, and jellyfin-adapter with a small helper that builds log-safe request descriptors via plain string ops, and normalize base URLs on construction. Preserves per-request baseURL overrides and params in failure logs, and closes the CodeQL server-side-request-forgery alert on external-api.service.ts. * fix: drop base URL normalizer to keep CodeQL SSRF fix minimal The added normalizeExternalApiBaseUrl used new URL(baseUrl), which CodeQL treats as a URL-construction sink. That gave its SSRF query a cleaner dataflow path from user config into every downstream axios request, producing four new alerts on the request call sites in external-api.service.ts. Removing the normalizer keeps only describeRequestTarget, which builds log strings via plain string ops and encodeURIComponent, and closes the original alert without introducing new ones.
enoch85
approved these changes
Apr 12, 2026
Contributor
|
🚀
|
Contributor
Author
|
🎉 This PR is included in version 3.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Promotes the current
developmentbranch state tomainfor release.Notes
developmentis the source branch for ongoing work.mainis the stable release branch../release.sh prepare-pr.Release 2 - Queue Push PR To Main.Release 2.5 - Execute Push PR To Mainreloads the PR state, confirms the approving CODEOWNER still has an active approval, waits for non-release checks to finish, then continues the remaining release steps.main, sync back branches, and runRelease 4 - Build Main.Release 5 - Publishfinishes with a second sync-back so the semantic-release commit onmainis merged back intodevelopment.mainwithREF=main ./release.sh release.Test Plan
./release.sh prepare-prRelease 2 - Queue Push PR To MainandRelease 2.5 - Execute Push PR To Mainmain, sync-back completed, andRelease 4 - Build MainfinishedREF=main ./release.sh releaseRelease 5 - Publishsynced the release commit frommainback intodevelopment