Open
Conversation
monzchan
reviewed
Dec 9, 2024
| " raise ValueError(\"Invalid operation. Please choose 'mean', 'max', or 'min'.\")\n", | ||
| " return result\n", | ||
| "#example\n", | ||
| "result = patient_summary('C:\\\\Users\\\\khate\\\\python\\\\05_src\\\\data\\\\assignment_2_data\\\\inflammation_11.csv','mean')\n", |
There was a problem hiding this comment.
you may use all_paths[0] here instead of the pathway for the file.
monzchan
suggested changes
Dec 9, 2024
monzchan
left a comment
There was a problem hiding this comment.
Using all_paths[x] in the script after defining all_paths will keep thing simple and convenient if there is any change in definition of all_paths, and also easier to locate files.
monzchan
approved these changes
Dec 9, 2024
monzchan
left a comment
There was a problem hiding this comment.
Good work for assignment 2! You may consider using the variables defined instead of the file pathway next time :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Submission of assignment-2
What did you learn from the changes you have made?
alot
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
yes - I was stuck in csv.reader or readline(s), I was not sure why I should go with readline since reader gives a better breakdown of csv
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
yes
How were these changes tested?
running the test in jnb
A reference to a related issue in your repository (if applicable)
Checklist