PointData problems with large data files bug fixed#1231
Merged
jeggermont merged 2 commits intomasterfrom Mar 19, 2026
Merged
Conversation
…_t so computation of indices will default to be done using 64-bit unsigned rather than 32-bit unsigned integrals. Changed a lot of unsigned and other integral datatypes to std::uint64_t so computation of indices will default to be done using 64-bit unsigned rather than 32-bit unsigned integrals.
…ems to cause problems with Linux builds. Explicit conversions from std::uint64_t to QVariant added since it seems to cause problems with Linux builds.
ThomasKroes
approved these changes
Mar 19, 2026
Contributor
ThomasKroes
left a comment
There was a problem hiding this comment.
It might be worth introducing type aliases (e.g., dim_idx) for iteration indices and using them consistently across the core for clarity and type safety.
ThomasKroes
pushed a commit
that referenced
this pull request
Mar 31, 2026
* Changed a lot of unsigned and other integral datatypes to std::uint64_t so computation of indices will default to be done using 64-bit unsigned rather than 32-bit unsigned integrals. Changed a lot of unsigned and other integral datatypes to std::uint64_t so computation of indices will default to be done using 64-bit unsigned rather than 32-bit unsigned integrals. * Explicit conversions from std::uint64_t to QVariant added since it seems to cause problems with Linux builds. Explicit conversions from std::uint64_t to QVariant added since it seems to cause problems with Linux builds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed a lot of unsigned and other integral datatypes to std::uint64_t so computation of indices will default to be done using 64-bit unsigned rather than 32-bit unsigned integrals. Closes #1230