Open
Conversation
Updated SQL query to use COALESCE for handling NULL values in product details.
niyazmnazari
approved these changes
Nov 26, 2025
niyazmnazari
left a comment
There was a problem hiding this comment.
Thank you for submitting assignment 2. All sections are correct.
Mark: 70/70
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
modified the Assignment2.md for answering the type1 and type2 SCD
added 2 png for ERD
modified the Assignment2.sql for SQL questions
What did you learn from the changes you have made?
more familiar with the windowed functions
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
was using with clause on most of the SQL Questions, but probably can use temporary tables
some of the Question that use the windowed functions that probably can use max and min inline query to get the same reason
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
no big challenges. it is more like google for the syntax of the SQL
How were these changes tested?
the changes was testing section by section like test each of the with clause first and cross check manually with list out the reason if their output as expected.
A reference to a related issue in your repository (if applicable)
I guess the problem I branch out from assignment-one branch, so the pull request from assignment-two to main. it also included assignment-one changes.
Checklist