Open
Conversation
juliagallucci
approved these changes
Feb 17, 2025
juliagallucci
left a comment
There was a problem hiding this comment.
Good! Nice use of char.isalnum() to ensure only alphanumeric characters (letters and numbers) are considered and ensuring valid input types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
I completed assignment 1 for the module of Python.
What did you learn from the changes you have made?
I learned how to do a function and how to verify its functionality
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
I would like to create a more complex scenario in which the function is not limited to two inputs but can evaluate any number of inputs. One approach would be to use *args.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
The main challenge was to learn how to write unit tests to evaluate the function's functionality using edge cases. I searched for information in the unit test library documentation and online tutorials.
How were these changes tested?
I run the cells using the designated environment kernel for the course.
A reference to a related issue in your repository (if applicable)
N/A
Checklist