Open
Conversation
Owner
Author
|
I noticed that I used the branch assignment-1 as base for creating the assignment-2 branch. |
kelichiu
approved these changes
Mar 2, 2025
kelichiu
left a comment
There was a problem hiding this comment.
Complete
Code Execution
All code cells execute without errors.
Code Quality
Code is well-organized, concise, and includes necessary comments for clarity.
Data Handling
Data files are correctly handled and processed.
Adherence to Instructions
Follows all instructions and requirements as per the assignment.
Specific Criteria
- Reading in our files
Correctly prints out information from the first file. - Summarizing our data
Correctly defines patient_summary() function. Function processes data as per operation and outputs correctly shaped data (60 entries). - Checking for Errors
Correctly defines detect_problems() function. Function uses patient_summary() and check_zeros() to identify mean inflammation of 0 accurately.
Overall Assessment
Exceeds all the general and specific criteria, indicating a strong understanding of the assignment objectives. Demonstrate extended skills by extra efforts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
I'm submitting the second assignment for the Python module.
What did you learn from the changes you have made?
I learn how to read files, how to make a function to use numpy to calculate the mean, max and min of data in a CSV file, and how to create a function to detect anomalies in the data.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
I considered extending the functionality of the last function to detect which patient record has faulty data. One approach that I could consider is to detect the row that has a mean equal to zero and then return True and the index; otherwise, it would return False and None.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
I have troubles in the first part to effectively using the paths given, I figured out I has to change the working directory in order to use them as they are, otherwise I would have to use the absolute path, which could cause troubles in other environments or for other users. I had to change the working directory using the current directory and looking for the python folder and use the parent directory.
How were these changes tested?
I run some simple tests in the jupyter notebooks
A reference to a related issue in your repository (if applicable)
Checklist