Conversation
Comment on lines
+3
to
+5
| String name; | ||
| int speed; | ||
|
|
There was a problem hiding this comment.
🍏 Лучше пометить эти поля как private и добавить для них геттеры/сеттеры. О них можно почитать здесь https://javarush.com/groups/posts/1928-getterih-i-setterih
| } | ||
| } | ||
| rootProject.name = "BillCalculator" | ||
| rootProject.name = "Java-Module-Project" |
There was a problem hiding this comment.
🍏 Некоторые лишние изменения вошли в пуллреквест из-за неправильной работы с ветками.
Оставлю памятку по работе с ветками на будущее
Comment on lines
+8
to
+10
| final int AMOUNT_CARS = 3; | ||
| final int MAX_SPEED = 250; | ||
| final int MIN_SPEED = 0; |
There was a problem hiding this comment.
👍 Круто, что вынес в константы эти значения
Comment on lines
+38
to
+39
| } catch (NumberFormatException error) { | ||
| System.out.println("Введены некорректное значение скорости. Попробуй ещё. \nЯ в тебя верю, на этот раз у тебя обязательно получится!"); |
There was a problem hiding this comment.
👍 Здорово, что обработал некорректный ввод
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Это мой Pull Request, вы только посмотрите!