Open
Conversation
faritowich
reviewed
Sep 27, 2022
|
|
||
| class Input { | ||
|
|
||
| public static int inputCheckInt(){ |
There was a problem hiding this comment.
Лучше использовать такие названия, чтобы было сразу понятно, для чего данный класс/метод/переменная нужны. Например, метод inputCheckInt() нужен для обработки ввода количества людей - лучше и назвать соответствующе, например, calculatePersons(). То же касается других названий - inputCheckDouble(), класса Input, Stuff и др.
Эта тема хорошо раскрывается во 2 главе книги Роберта Мартина "Чистый код", рекомендую к прочтению. Также на хабре есть краткий конспект книги: https://habr.com/ru/post/485118/
| } | ||
| return rubResult; | ||
| } //рубль/ля/лей | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pr1