Skip to content

Input bar fixes continued#384

Merged
nathantannar4 merged 2 commits intodevelopmentfrom
inputBarFixesContinued
Dec 8, 2017
Merged

Input bar fixes continued#384
nathantannar4 merged 2 commits intodevelopmentfrom
inputBarFixesContinued

Conversation

@nathantannar4
Copy link
Copy Markdown
Member

@nathantannar4 nathantannar4 commented Dec 7, 2017

Found the issue with PR #380

Before I thought it was correct to change the bottomAnchor to the window, after some digging it looks like we just needed to add an extra constraint and leave the old one.

@SD10 SD10 changed the base branch from master to development December 7, 2017 21:07
@SD10
Copy link
Copy Markdown
Member

SD10 commented Dec 7, 2017

@nathantannar4 once you're done with finals, we'll discuss how we can write tests for the MessageInputBar together. This should make your life easier and expose any existing flaws.

@nathantannar4 nathantannar4 merged commit a166b11 into development Dec 8, 2017
@SD10 SD10 deleted the inputBarFixesContinued branch December 8, 2017 03:44
@SD10 SD10 mentioned this pull request Dec 18, 2017
2 tasks
@girishghoda
Copy link
Copy Markdown

Hi @nathantannar4
i have latest version : 0.12.0 ,But still inputbar issue occur
When i open chat view then show inputbar & after 1 or 2 second it hide automatically
img_0176
I had spent lot of time in chat functionality please help as soon as possible
Thanks

@nathantannar4
Copy link
Copy Markdown
Member Author

I'm going to need more information to debug this. Is this a child view controller, any custom controllers, can you reproduce this in the example? This PR was for other things. Maybe message me on slack

Sent with GitHawk

@girishghoda
Copy link
Copy Markdown

girishghoda commented Dec 22, 2017 via email

@nathantannar4
Copy link
Copy Markdown
Member Author

Ah I think you need to call becomeFirstResponder https://github.com/MessageKit/MessageKit/blob/master/Documentation/FAQs.md

Sent with GitHawk

@girishghoda
Copy link
Copy Markdown

Hi @nathantannar4

Here i explain my code:
First way :

Prevview :
self.navigationController?.pushViewController(chatViewController, animated: true)

Chatview:
class GrpMessageViewController: MessagesViewController
this way first time inputbar show & imediatly hide

Second way:

as per you said i tried with below code

  1. class GrpMessageViewController: UIViewController
  2. messagesViewController = MessagesViewController()
    addChildViewController(messagesViewController)
    self.view.addSubview(messagesViewController.view)
    messagesViewController.didMove(toParentViewController:self)
    self.becomeFirstResponder()

after this code inoutbar does't show (even first time not show)

Thanks

@girishghoda
Copy link
Copy Markdown

Hey @nathantannar4
Its solved
Actually problem in Material framework navigationcontroller

When i use this way

let myNavigationController = UINavigationController(rootViewController: chatViewController)
self.present(myNavigationController, animated: true, completion: nil)
then it show properly
Thanks

@SD10
Copy link
Copy Markdown
Member

SD10 commented Dec 23, 2017

@girishghoda Please move this discussion to a GitHub issue 👍. This PR is not the place for it

@MessageKit MessageKit locked as off-topic and limited conversation to collaborators Dec 23, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants