Skip to content

Cache table columns locally #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stefanheimes merged 4 commits into from
Aug 27, 2019
Merged

Cache table columns locally #77

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
84e9e68
Cache table columns locally
Aug 23, 2019
d29c839
add myself as author
Aug 23, 2019
f5a019e
fix coding style
Aug 23, 2019
5fd3f1d
coding style and undefined index fix
Aug 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions src/Attribute/AttributeOrderTypeFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
*
* @package MetaModels/attribute_file
* @author Sven Baumann <[email protected]>
* @author Benedict Zinke <[email protected]>
* @copyright 2012-2019 The MetaModels team.
* @license https://github.com/MetaModels/attribute_file/blob/master/LICENSE LGPL-3.0-or-later
* @filesource
Expand Down Expand Up @@ -42,6 +43,13 @@ class AttributeOrderTypeFactory implements IAttributeTypeFactory
*/
protected $tableManipulator;

/**
* Cache table columns.
*
* @var array
*/
private $tableColumns = [];

/**
* {@inheritDoc}
*
Expand Down Expand Up @@ -78,9 +86,14 @@ public function getTypeIcon()
*/
public function createInstance($information, $metaModel)
{
$columnName = ($information['colname'] ?? null);
$tableColumns = $this->connection->getSchemaManager()->listTableColumns($metaModel->getTableName());
if (!$columnName || !\array_key_exists($columnName, $tableColumns)) {
$columnName = ($information['colname'] ?? null);
$tableName = $metaModel->getTableName();

if (!isset($this->tableColumns[$tableName])) {
$this->tableColumns[$tableName] = $this->connection->getSchemaManager()->listTableColumns($tableName);
}

if (!$columnName || !\array_key_exists($columnName, $this->tableColumns[$tableName])) {
return null;
}

Expand Down