Fix EEXIST errors in zipfile.py during extraction#54
Merged
ThomasFarstrike merged 1 commit intoMicroPythonOS:mainfrom Feb 21, 2026
Merged
Conversation
When extracting zip archives, os.mkdir() could raise [Errno 17] EEXIST in two places: 1. makedirs() - A directory might already exist between the path_exists check and the os.mkdir() call, or be created by a prior extraction step. 2. _extract_member() - makedirs() may have already created a directory when building parent paths for a file entry, and then a separate directory entry for the same path triggers os.mkdir() again. Wrap both os.mkdir() calls in try/except OSError to handle this gracefully. Co-Authored-By: Claude Opus 4.6 <[email protected]>
Contributor
|
I haven't noticed this issue, as it's doing a "check if exists" before trying, no? But okay... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
os.mkdir()inmakedirs()and_extract_member()withtry/except OSErrorto prevent[Errno 17] EEXISTcrashes during zip extractionmakedirs()for a file's parent path, and then a separate directory entry for the same path triggersos.mkdir()againmakedirs()races between itspath_exists()check and theos.mkdir()callTest plan
🤖 Generated with Claude Code