add API subscription & Gopay Tokenization implementation#22
add API subscription & Gopay Tokenization implementation#22omarxp merged 21 commits intoMidtrans:masterfrom
Conversation
omarxp
commented
Nov 9, 2021
- Add API Subscription
- Add Gopay Tokenization
- Add sample
- Add test
rizdaprasetya
left a comment
There was a problem hiding this comment.
Some changes are needed before this PR can be approved, please update ya. Thanks
README.md
Outdated
| } | ||
| create_subscription = subscription.create(param) |
There was a problem hiding this comment.
Please explain this on the readme: Before merchant can call API create subscription, merchant should first obtain the 1 click token (which you can link it to this docs: https://docs.midtrans.com/en/core-api/advanced-features?id=recurring-transaction-with-subscriptions-api )
|
@rizdaprasetya new commit |
rizdaprasetya
left a comment
There was a problem hiding this comment.
Still need some updates, other than that looks good 👍
|
@rizdaprasetya updated with new commit |
rizdaprasetya
left a comment
There was a problem hiding this comment.
Few things need to be fixed. Also the commit message is not very descriptive, as always reminded before, please use proper & descriptive commit message next time.
|
@rizdaprasetya I use https://dillinger.io as markdown editor, should be fix now |
rizdaprasetya
left a comment
There was a problem hiding this comment.
Few changes needed @omarxp . thanks
README.md
Outdated
| You will receive gopay payment token with get_payment_account API | ||
| Check Tokenization examples folder (/examples/tokenization) |
There was a problem hiding this comment.
The example link doesn't get rendered properly, there is no spacing or proper dot punctuation between 2 sentences. Please fix & be more careful.
Also proper grammar should be:
You will receive gopay payment token using
get_payment_accountAPI call.
The render result of that tool seems different than Github, always test from user perspective, user will view it directly from Github, so you should too. All the screenshot I took from Github's markdown render. |
|
@rizdaprasetya updated with new commit |
rizdaprasetya
left a comment
There was a problem hiding this comment.
Still found some issue, please fix @omarxp
rizdaprasetya
left a comment
There was a problem hiding this comment.
additional feedback
|
@rizdaprasetya please help to check again |
rizdaprasetya
left a comment
There was a problem hiding this comment.
Great, looks good now. Please merge and release, thanks! @omarxp (will share account creds via Slack)