Open
Conversation
juliagallucci
approved these changes
May 6, 2024
juliagallucci
left a comment
There was a problem hiding this comment.
Great job! Your code is well executed and commented- Nice inclusion of a docstring !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
I'm trying to add the code of an anagram checker in Python. Refactoring the exiting code to include case sensitive as option in the anagram checker function. Add comments to the code to clarify and understand and test the code.
What did you learn from the changes you have made?
I've learned or at least tried to learn how to implement an anagram checker function. How to modify the function to include case sensitive as an option. Importance of testing the function with various inputs to insure it is correct. How to structure the code with comments for better readability and understanding and how to use booleans to control the behaviour as a function based on user preferences
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Not Really
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
Starting the assignments in the assignment_1.ipynb file was quite challenging for me. Before delving into the tasks, I spent some time testing and experimenting with the concepts covered in the lessons. This included understanding logical operators, exploring the OHIP Eye Exam Function, reviewing sample functions, formatting strings using escape sequences and f-strings, and grasping slicing techniques.
How were these changes tested?
A reference to a related issue in your repository (if applicable)
IndentationError: expected an indented block (I faced this error)
@mentions of the person or team responsible for reviewing proposed changes (At least 2 people)
Checklist