Skip to content

2489: Replace charts using Chart.js#2500

Merged
KralMarko123 merged 11 commits intomasterfrom
2489
Mar 9, 2026
Merged

2489: Replace charts using Chart.js#2500
KralMarko123 merged 11 commits intomasterfrom
2489

Conversation

@KralMarko123
Copy link
Copy Markdown
Collaborator

Feature for #2489

  • Added functions to new_charts.js for rendering all charts
  • Removed any calls to Highcharts.js in existing views and replaced with loading in new_charts.js

Disclaimer: Each function in new_charts.js is respectively its own chart, trying to be smart and using shared methods for different charts actually became more convoluted, this way if a chart needs changing we just need to alter one method rather than have dependencies everywhere.

@KralMarko123 KralMarko123 requested a review from tomca32 March 8, 2026 17:03
Copy link
Copy Markdown
Member

@tomca32 tomca32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on this.

As a simple improvement, we could by default show the last month of data for a selected filter....it's a bit annoying having to hunt for data not knowing when are the latest datapoints.

@KralMarko123 KralMarko123 merged commit 0c193a3 into master Mar 9, 2026
4 checks passed
@KralMarko123 KralMarko123 deleted the 2489 branch March 9, 2026 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants