Merged
Conversation
…f non-document nodes
pwc3
requested changes
Sep 30, 2021
Contributor
pwc3
left a comment
There was a problem hiding this comment.
This looks great. Would it be possible to get some unit test coverage on this?
Formatter enhancements
Collaborator
Author
|
@pwc3 Added some tests |
Collaborator
Author
|
@pwc3 Is this good to merge? |
pwc3
approved these changes
Oct 22, 2021
Contributor
|
Good to merge whenever you're ready |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For large documents it can be necessary to terminate search early and/or filter out entire subtrees from the search.