Open
Conversation
…ing set would not work
|
Assignment marked. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
I am adding code that overall evaluates patients medical records that evaluates the effectiveness of a fictional medication designed to reduce inflammation by arthritic flare-ups. Specifically I am trying to create a loop to ensure that the detect_problems function can evaluate each patient in the file list to make sure there are not any patients with zero mean inflammation scores.
What did you learn from the changes you have made?
I learned the usefulness of helper functions which makes other functions more readable and concise. In addition, I learned the power of using for loops for iteration.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
I was thinking about instead of going through each file path, a function could read through all the file paths within a certain directory (all_paths). This would look like another for loop that would run over all_paths.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
Some challenges were making sure that the file paths were connecting correctly and that the detect_problems function was running correctly for all of the file paths that I may test. I made sure by testing the function out with multiple different file paths and checking in my C drive that the original files did indeed have or not have zero mean.
How were these changes tested?
On top of checking manually and testing out different file paths, I also checked the loop structure and used f-string to check whether each file contained any patients with zero mean inflammation score.
A reference to a related issue in your repository (if applicable)
Checklist