Open
Conversation
niyazmnazari
approved these changes
Sep 20, 2024
niyazmnazari
left a comment
There was a problem hiding this comment.
Thank you for submitting your homework!
8/8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
I am trying to add and modify SQL queries so that I'm using windowed functions, string manipulations and unions.
What did you learn from the changes you have made?
I learned that windowed functions and unions are quite powerful, especially in ranking cases.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
I thought about using dense rank but i decided to use row_number instead because there might be unique cases of one customer visiting on different days.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
Not too much, but the union was a bit challenging so I had try it multiple times.
How were these changes tested?
Primarily through DB browser for SQLite.
A reference to a related issue in your repository (if applicable)
n/a
Checklist