Skip to content

feat: Added env var passthrough for dataset, preprocess, and runs cache directories in benchmark#35

Merged
melvinbarbaux merged 1 commit intomainfrom
chore/env-vars-yaml
Feb 17, 2026
Merged

feat: Added env var passthrough for dataset, preprocess, and runs cache directories in benchmark#35
melvinbarbaux merged 1 commit intomainfrom
chore/env-vars-yaml

Conversation

@melvinbarbaux
Copy link
Copy Markdown
Collaborator

Summary

What does this PR change?

Checklist

  • Tests added or updated
  • CI green
  • Changelog updated
  • Documentation updated

Notes

Anything reviewers should know?

@melvinbarbaux melvinbarbaux self-assigned this Feb 17, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@melvinbarbaux melvinbarbaux merged commit 0aa91d4 into main Feb 17, 2026
9 checks passed
@melvinbarbaux melvinbarbaux deleted the chore/env-vars-yaml branch February 17, 2026 02:02
@chatgpt-codex-connector
Copy link
Copy Markdown

💡 Codex Review

cache_dir: /home/mbarbaux/scratch/ModSSC/cache/graphs

P1 Badge Remove hard-coded graph cache path from best configs

The new graph.cache_dir value is pinned to /home/mbarbaux/scratch/ModSSC/cache/graphs, which makes graph-enabled benchmark configs fail on machines where that user path is missing or not writable (a common case for non-root users and CI runners). This commit introduced that absolute path into many best configs, replacing the previous behavior where graph caching used the library default location; these experiments can now abort with permission/path errors unless users manually edit every config.


return os.path.expandvars(value)

P2 Badge Fail fast on unresolved env placeholders in YAML

os.path.expandvars leaves unknown variables unchanged, so when MODSSC_OUTPUT_DIR/MODSSC_DATASET_CACHE_DIR/MODSSC_PREPROCESS_CACHE_DIR are not exported, placeholders like ${MODSSC_OUTPUT_DIR} silently survive and become literal directory names. Because this commit switched many benchmark configs to those placeholders, runs now quietly write to unintended paths instead of using prior defaults, which makes cache/output placement unreliable and hard to diagnose.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant