Skip to content

feat: add best benchmark configuration commands for all percentages#45

Merged
melvinbarbaux merged 1 commit intomainfrom
feat/add-best-benchmark-configs
Mar 1, 2026
Merged

feat: add best benchmark configuration commands for all percentages#45
melvinbarbaux merged 1 commit intomainfrom
feat/add-best-benchmark-configs

Conversation

@melvinbarbaux
Copy link
Copy Markdown
Collaborator

Summary

What does this PR change?

Checklist

  • Tests added or updated
  • CI green
  • Changelog updated
  • Documentation updated

Notes

Anything reviewers should know?

@melvinbarbaux melvinbarbaux merged commit 2cc8bb6 into main Mar 1, 2026
7 checks passed
@melvinbarbaux melvinbarbaux deleted the feat/add-best-benchmark-configs branch March 1, 2026 23:15
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 416709d343

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

## Kind: inductive
### Modality: audio
```bash
python -m bench.main --config bench/configs/experiments/best/p01/inductive/adamatch/audio/speechcommands.yaml
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Point runbook commands to the real config directory

Any command copied from these runbooks fails with file not found because the path prefix is bench/configs/experiments/best/..., but this commit actually adds the configs under bench/configs/best/... (there is no bench/configs/experiments/best tree). As written, the documented benchmark commands are not executable in the current repository layout.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant