Conversation
| }, | ||
| "outputs": [], | ||
| "source": [ | ||
| "with open(all_paths[0], 'r') as f:\n", |
There was a problem hiding this comment.
Please delete this line of code here. This code will not run without defining the all-paths, so this code should not be in front of the all_paths definition.
| " # if the operation is not one of the expected values, raise an error\n", | ||
| " raise ValueError(\"Invalid operation. Please choose 'mean', 'max', or 'min'.\")\n", | ||
| "\n", | ||
| " return summary_values" |
There was a problem hiding this comment.
here you have defined 'result' as mean, max and min, but at the end you return 'summary_values'. So, summary_values is not deinfed and next code could not run
| "source": [ | ||
| "# Define your function `detect_problems` here\n", | ||
| "\n", | ||
| "def detect_problems(file_path):\n", |
There was a problem hiding this comment.
this code was doubled here. please delete one
|
It looks like there are no changes in your Unfortunately, the assignment 2 notebook in the Here’s what I recommend instead:
This will help you avoid spreading the issues from |
|
Hi Daniel,
Hope you are well.
I made file changes by pressing the edit button. Other than that who can i reach out for support, as this week’s learning support was unable to help.
I would have made the changes earlier but Pedram on slack sent a message that my Python assignment is marked complete.
Kindly please help me as i am running out of time yo make changes.
Regards,
Gulrukh Aqeel
…Sent from my iPhone
On Dec 19, 2024, at 11:54 AM, Daniel Razavi ***@***.***> wrote:
It looks like there are no changes in your assignment-2 branch pull request. I noticed you made changes recently, so I investigated further. It turns out the changes you made were on the patch-2<https://github.com/Mrs-Aqeel/python/tree/patch-2> branch, not the assignment-2 branch.
Unfortunately, the assignment 2 notebook in the patch-2 branch is broken. It seems that some lines were deleted, which has caused the notebook's underlying JSON to become invalid. As a result, the notebook cannot be opened or rendered properly in Visual Studio Code. Because of this, I strongly recommend that you do not merge patch-2 into assignment-2 or any other branch. Merging would carry over these issues to other branches and break them as well.
Here’s what I recommend instead:
1. Review the changes you made in the patch-2 branch.
2. Reapply those changes manually to the assignment-2 branch without copying the broken parts.
This will help you avoid spreading the issues from patch-2. Also, make sure not to merge the assignment-2 branch into main until your work is complete and the notebook is functioning properly.
—
Reply to this email directly, view it on GitHub<#2 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BM3IO4QGAMHO5VXFLOAZQ232GL25JAVCNFSM6AAAAABTGIS2L6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNJVGA3TQNZVGY>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
i entered the desired codes
What did you learn from the changes you have made?
i learnt the for loops
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
i did what i thought was the right approach
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
How were these changes tested?
by running codes
A reference to a related issue in your repository (if applicable)
NA
Checklist
I can confirm that my changes are working as intended
CONFIRM