Complete Refactor of MultiChatSpigot and MultiChatSponge to MultiChatLocal#85
Merged
OllieMartin merged 134 commits intomasterfrom May 2, 2020
Merged
Complete Refactor of MultiChatSpigot and MultiChatSponge to MultiChatLocal#85OllieMartin merged 134 commits intomasterfrom
OllieMartin merged 134 commits intomasterfrom
Conversation
Upgrade chat handling on Sponge to be in line with that on Spigot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a complete refactor of the Spigot and Sponge parts of MultiChat into a new common API called MultiChatLocal.
This will allow for easier support of both these platforms, and any new platforms in the future.
This is also a way to massively improve the quality of the code.
Additionally, the door will be opened to other plugins wishing to make use of the new API.