Skip to content

Implemented "New Pickaxes" feature#195

Merged
Monniasza merged 8 commits intoMultiMachineBuilder:masterfrom
PKCPablo:master
Dec 14, 2023
Merged

Implemented "New Pickaxes" feature#195
Monniasza merged 8 commits intoMultiMachineBuilder:masterfrom
PKCPablo:master

Conversation

@PKCPablo
Copy link
Contributor

@PKCPablo PKCPablo commented Dec 13, 2023

Fixes #127

Added the following pickaxes:

  • Stone - 150 durability, 1s to mine a block
  • Iron - 250 durability, 640ms to mine a block
  • Steel - 350 durability, 400 ms to mine a block
  • Stainless - 600 durability, 280 ms to mine a block

Added textures, recipes and translation

  • Stone Pickaxe
  • Iron Pickaxe
  • Steel Pickaxe

Changed

  • Rudimentary Pickaxe to 200 durability

@Monniasza
Copy link
Member

@PKCPablo You have not linked PR to the issue.

@PKCPablo
Copy link
Contributor Author

@Monniasza how i do that?

@Monniasza
Copy link
Member

@PKCPablo Type "Fixes " before the issue number

@PKCPablo
Copy link
Contributor Author

@Monniasza now it is i think

@Monniasza
Copy link
Member

@PKCPablo You have not created the iron pickaxe, and used iron for one of steel pickaxe recipes.

@PKCPablo
Copy link
Contributor Author

@Monniasza fixed

@Monniasza
Copy link
Member

Translate pickaxes into Polish, creating entries in Polish dictionary.

@PKCPablo
Copy link
Contributor Author

It's translated. I used DeepL to translate it, so check the translation in case it doesn't make sense.

@Monniasza
Copy link
Member

@PKCPablo Items in recipes do not form nice columns.

@Monniasza
Copy link
Member

@PKCPablo I've not finished refactoring. I'll suggest my refactoring after I'm done with it.

@Monniasza Monniasza self-assigned this Dec 14, 2023
@Monniasza Monniasza added this to the 0.5.1 milestone Dec 14, 2023
@Monniasza Monniasza added the Type: enhancement New feature or request label Dec 14, 2023
@Monniasza
Copy link
Member

@PKCPablo Merge my repo into your pull request.

@PKCPablo
Copy link
Contributor Author

@Monniasza how do I do that??

@Monniasza
Copy link
Member

@PKCPablo click on "Sync fork" and confirm.

@PKCPablo
Copy link
Contributor Author

PKCPablo commented Dec 14, 2023

@Monniasza i think it's now done

@PKCPablo
Copy link
Contributor Author

@PKCPablo Items in recipes do not form nice columns.

oh, it appears nice for me:
image

@Monniasza
Copy link
Member

@PKCPablo Set your tab width to 4 spaces.

@Monniasza
Copy link
Member

Monniasza commented Dec 14, 2023

@PKCPablo Add item tags to pickaxes.

@PKCPablo
Copy link
Contributor Author

@Monniasza where should I put the tags??

@Monniasza
Copy link
Member

@PKCPablo Add them in the static initializer on the same line as other pickaxes.

@PKCPablo
Copy link
Contributor Author

@Monniasza done!

@Monniasza
Copy link
Member

@PKCPablo Approved!

@Monniasza Monniasza merged commit f07a140 into MultiMachineBuilder:master Dec 14, 2023
@Monniasza Monniasza added the Close: done The bug has been fixed or a change implemented label Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Close: done The bug has been fixed or a change implemented Type: enhancement New feature or request

Projects

Status: Finished

Development

Successfully merging this pull request may close these issues.

New pickaxes

2 participants