Open
Conversation
…ns to turn on/off
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Jeff,
Thank you a lot for the wonderful macro! When using it, however, I found several severe bugs, some of which produce wrong/meaningless results, and others of which are due to incompatibility for higher versions of ImageJ. These commits can hopefully solve these issues and were also tested to be compatible for lower versions of ImageJ (1.51h).
To name a few: The algorithm of linear regression for calculation of correlation length was wrong; the presentation of LER and LWR analysis was not well-organized; for ImageJ >=1.52d, the dyeing of the skeleton for correlation length calculation and the orientational domain map was incorrect.
A detailed description of the bugs I found and each commit can be found here.
Thanks again!
Cheers,
Z. Sun