Skip to content

CHORE: Fix stlying and linting steps in CI#590

Draft
anoop-surej-nhs wants to merge 5 commits intomainfrom
chore/linting-test
Draft

CHORE: Fix stlying and linting steps in CI#590
anoop-surej-nhs wants to merge 5 commits intomainfrom
chore/linting-test

Conversation

@anoop-surej-nhs
Copy link
Contributor

Description

There are quite a few bugs in the linting steps (forked over from repository template):

  1. All the steps use the main branch as comparison; for TBD, this means practically nothing is checked, as it compares main to main, and finds that there are no new changes, and so it does not run the steps.
  2. The above step also means that branches created from main will suffer, as bugs fall through, they will be caught only in non-main branches.
  3. There were already some file format/linting issues when we forked from repository template.

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

…Docker

- Seems there was a mistake in the original repository template as the original editorconfig (c core) package does not support the --exclude flag used in the check-file-format script
- Until now, the docker image for editorconfig-checker was used for the precommit.
- This docker image unfortunately does not play well with Apple Silicon macs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant