[WIP] Guard host managed-memory access on concurrentManagedAccess=0#1769
[WIP] Guard host managed-memory access on concurrentManagedAccess=0#1769rwgk wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
Guard host-side memset/memcmp in test helpers on CMA=0 by syncing the device before touching managed allocations. Made-with: Cursor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
There are no flakes in 100 trials with this PR at commit b611a87: Additional sanity check: |
|
Surprise: There are also no flakes with Additional sanity check: |
|
Note: I did not rebuild between running the tests reported under
I.e. everything was exactly identical, except for the presence/absence of commit b611a87. This is reflected in all log files, e.g.:
|
|
I don't know what changed, but I cannot reproduce the flakes anymore. All details are in the log files under Closing this PR and #1576 for now. If we see the flakes again later, we can come back here. |
xref: #1576 (comment)
This PR is:
Add a small helper (in
helpers/buffers.py) that callsDevice.sync()(orotherwise ensures no work is in flight) before any host
memset/memcmpofmanaged memory when
concurrentManagedAccess == 0. This is targeted andkeeps behavior unchanged on CMA=1 systems.