fix: allow workflow to run with no branches identified + support PR updates#1812
Merged
elezar merged 1 commit intoNVIDIA:mainfrom Oct 22, 2025
Merged
Conversation
d94c037 to
381ee2e
Compare
tariq1890
approved these changes
Oct 21, 2025
rahulait
reviewed
Oct 22, 2025
41d456c to
154e246
Compare
Member
|
Question: Does the bot update / recreate a PR if a user issues another comment? |
Member
Author
|
@elezar Not currently. We could have the bot use |
154e246 to
1a2440c
Compare
Member
Author
|
@elezar I just added support for PR updates. The bot now detects and updates existing backport PRs when users re-run /cherry-pick commands, using force-push to sync changes and updating PR descriptions with current conflict/merge status. We can now iteratively change backports w/o manual cleanup. |
cb5b622 to
1a2440c
Compare
elezar
approved these changes
Oct 22, 2025
Member
elezar
left a comment
There was a problem hiding this comment.
Thanks! Let's get this in and iterate!
1a2440c to
6e1494a
Compare
…riggers Signed-off-by: Karthik Vetrivel <[email protected]>
6e1494a to
316284b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cherrypick GitHub Action was running unconditionally on every PR merge. I initially thought this was fine but it caused unnecessary workflow runs and also led to failures. Failures are the bigger issue of the two.
Allow Cherry-Pick Bot to Backport PRs From Just Comments
Now, we can create backports at any point in the review process by using the
/cherry-pickcomment. This prevents running the GHA workflow on every merge and instead only when a user comments/cherry-pickChanges
pull_request_targettrigger, use only/cherry-pickcommentsUse Case
Run
/cherry-pick release-v1.0on an open PR to create a backport early. The bot warns if the source PR isn't merged yet.