ref(http): split http module to solve circular refs#11141
Merged
NathanWalker merged 6 commits intoNativeScript:mainfrom Mar 18, 2026
Merged
ref(http): split http module to solve circular refs#11141NathanWalker merged 6 commits intoNativeScript:mainfrom
NathanWalker merged 6 commits intoNativeScript:mainfrom
Conversation
|
View your CI Pipeline Execution ↗ for commit 6596627
☁️ Nx Cloud last updated this comment at |
CatchABus
added a commit
to CatchABus/NativeScript
that referenced
this pull request
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Right now, the http module is used for any purpose inside core and at the same time imports other modules from the same scope (e.g.
ImageSource).The same module is both for internal and public usage.
What is the new behavior?
Separate http response content functionality and create the
http-request-internalmodule for internal use.This ensures we expose the same http api for users while having a minimal http client to use internally.
Separating those comes with benefits:
toFilethat attempted to reject the fulfilled promise of the request itself