chore(core): updated layout tests to wait for native layer layout#11143
Merged
NathanWalker merged 1 commit intoNativeScript:mainfrom Mar 19, 2026
Merged
Conversation
|
View your CI Pipeline Execution ↗ for commit 8c50286
☁️ Nx Cloud last updated this comment at |
NathanWalker
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Right now, a couple of iOS automated layout tests are randomly failing.
The problem seems to be the timing as core does not expect for the native layout to complete. In the past, we attempted to get rid of the problem using OS version checks but that doesn't seem to be 100% accurate.
What is the new behavior?
Check if UIView layer is still marked as layout dirty before proceeding. This will give the tests enough time to run properly.
I'm not sure if it's the best approach, we could definitely force the layout to finish earlier using
layoutIfNeededbut I think it's also good to make use of the TKUnitwaitUntilReadycall.