Skip to content

feat: add CSS classes to app/modal root views to target platform/device/orientation/type#7606

Merged
vchimev merged 6 commits intomasterfrom
vchimev/root-views-css-classes
Aug 19, 2019
Merged

feat: add CSS classes to app/modal root views to target platform/device/orientation/type#7606
vchimev merged 6 commits intomasterfrom
vchimev/root-views-css-classes

Conversation

@vchimev
Copy link
Copy Markdown
Contributor

@vchimev vchimev commented Jul 29, 2019

PR Checklist

What is the new behavior?

Add a CSS class to the application/modal root view as follows:

application root view

  • default
    • .ns-root
  • platform
    • .ns-ios
    • .ns-android
  • device type
    • .ns-phone
    • .ns-tablet
  • orientation
    • .ns-portrait
    • .ns-landscape

modal root view

  • default
    • .ns-modal

Depends on #7602.
Implements #7313.

@MartoYankov MartoYankov added the docs needed Additional documentation on this issue/PR is needed label Aug 6, 2019
@vchimev vchimev force-pushed the vchimev/root-views-css-classes branch 3 times, most recently from 62e4707 to f6cba6d Compare August 18, 2019 11:45
Add CSS classes to app/modal root views to target platform/device/orientation/type.
@vchimev vchimev force-pushed the vchimev/root-views-css-classes branch from b7b8a0d to 3a2d062 Compare August 18, 2019 14:26
@vchimev vchimev requested a review from bundyo August 19, 2019 08:20
@vchimev vchimev merged commit 3adba68 into master Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes docs needed Additional documentation on this issue/PR is needed

Projects

Status: 🆕 New

Development

Successfully merging this pull request may close these issues.

4 participants