Skip to content

fix(android-list-picker): NoSuchFieldException on api29#7790

Merged
manoldonev merged 1 commit intoreleasefrom
mdonev/listpicker-api29
Sep 10, 2019
Merged

fix(android-list-picker): NoSuchFieldException on api29#7790
manoldonev merged 1 commit intoreleasefrom
mdonev/listpicker-api29

Conversation

@manoldonev
Copy link
Copy Markdown
Contributor

Note that Android ListPicker.color property had some weird get/set arguments and return values that I have now removed because as far as I can see:

  • These were never documented as public API, could not find any sample usage, or references anywhere
  • Setting different values for wheelColor and textColor worked only on initial load of the compoent, once you started scrolling textColor was lost and the input text was painted with wheelColor
  • Now that api29 introduces proper public methods for manipulating this functionality, it exposed a single NumberPicker.setTextColor(...) native method that sets both wheelColor and textColor (in the older terms).

Fixes: #7785

@manoldonev manoldonev self-assigned this Sep 5, 2019
@cla-bot cla-bot bot added the cla: yes label Sep 5, 2019
@dtopuzov
Copy link
Copy Markdown
Contributor

dtopuzov commented Sep 9, 2019

test package_version#latest

@manoldonev manoldonev merged commit 997d6de into release Sep 10, 2019
@manoldonev manoldonev deleted the mdonev/listpicker-api29 branch September 10, 2019 10:38
manoldonev added a commit that referenced this pull request Sep 12, 2019
* feat(android): fix tab resource icon size based on spec (#7737)

* feat(ios): add icon rendering mode for bottom navigation (#7738)

* fix(ios-tabs): crash when add tabstrip in loaded event (#7743)

* fix(css): parse css selectors with escape sequences (#7689) (#7732)

* fix(ios-tabs): handle nesting proxy view container (#7755)

* fix-next(css): className to preserve root views classes (#7725)

* docs: cut the 6.1.0 release (#7773)

* fix(android-list-picker): NoSuchFieldException on api29 (#7790)

* chore: hardcode tslib version to 1.10.0 (#7776)

* fix(css-calc): reduce_css_calc_1.default is not a function (#7787) (#7801)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants