fix(android): Request Timeout #6523#8194
Merged
vtrifonov merged 3 commits intoNativeScript:masterfrom Jan 9, 2020
Merged
Conversation
Fix http requests to use read timeout in addition to connect timeout.
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Jesse Taina.
|
Contributor
|
@SpurguX thanks for your contribution! Could you sign the CLA, please! |
vakrilov
approved these changes
Dec 20, 2019
This was referenced Mar 20, 2020
This was referenced Apr 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix http requests to use read timeout in addition to connect timeout.
PR Checklist
What is the current behavior?
Http timeout doesn't work as expected #6523 . When timeout is set, the request times out only if connection is not established within the timeout threshold.
What is the new behavior?
When timeout is set, the request will time out when the request has not completed within the timeout threshold. This can be due to failed connection or a response that takes too long to finish.
Fixes/Implements/Closes #6523 .
WIP - Writing Tests
I'm not sure how I should proceed with regard to writing the tests for a few reasons: