fix(css): parse css selectors with escape sequences (for real)#8496
Merged
vtrifonov merged 4 commits intoNativeScript:masterfrom Apr 3, 2020
Merged
fix(css): parse css selectors with escape sequences (for real)#8496vtrifonov merged 4 commits intoNativeScript:masterfrom
vtrifonov merged 4 commits intoNativeScript:masterfrom
Conversation
vtrifonov
reviewed
Apr 3, 2020
Contributor
|
LGTM 👍 (after adding the semicolon) |
vtrifonov
approved these changes
Apr 3, 2020
Member
|
@RedHatter I just spent the last hour or so debugging the |
NathanWalker
pushed a commit
that referenced
this pull request
Aug 7, 2020
* fix(css): CSS escape sequences * Missing semicolon Co-authored-by: Vasil Trifonov <[email protected]>
NathanWalker
pushed a commit
that referenced
this pull request
Aug 7, 2020
* fix(css): CSS escape sequences * Missing semicolon Co-authored-by: Vasil Trifonov <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently NativeScript doesn't correctly parse escape sequences in CSS selectors. There was an issue and PR (#7688, #7689) about this problem previously but only escaping a slash was implemented. My PR fully supports escape sequence from the spec. This includes escaping any character or Unicode sequence.
PR Checklist