Skip to content

Completed assignment 1#1

Open
Nicole-Hong wants to merge 1 commit intomainfrom
assignment_one
Open

Completed assignment 1#1
Nicole-Hong wants to merge 1 commit intomainfrom
assignment_one

Conversation

@Nicole-Hong
Copy link
Copy Markdown
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

What did you learn from the changes you have made?

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

How were these changes tested?

A reference to a related issue in your repository (if applicable)

Checklist

  • I can confirm that my changes are working as intended

Copy link
Copy Markdown

@xindizhang xindizhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work! Your code is clean and well-written. Your assignment 1 is complete – no changes needed.

Please see my suggestions for future improvement:

  • In places like:
  if sorted(word_a.lower()) == sorted(word_b.lower()):
        return True
  else:
        return False

You can simplify this by directly returning the boolean expression:
return sorted(word_a.lower()) == sorted(word_b.lower())
This makes the code cleaner

  • Instead of if is_case_sensitive == True:, you can use if is_case_sensitive:. In Python, booleans already evaluate directly in conditions. That way your code is cleaner. (if is_case_sensitive == False: -> if not is_case_sensitive:
  • for if sorted(word_a.lower()) == sorted(word_b.lower()) and sorted(word_a) == sorted(word_b), Repeating sorted() is unnecessary; the first condition already covers case-insensitive comparison
  • It’s good practice to add comments or brief documentation to your code so it’s easier for you to review and debug later, and for teammates to understand quickly.
  • Quick reminder for future submissions — including a brief PR description is good practice, as it helps your "project-mate" quickly understand what’s going on.

@xindizhang
Copy link
Copy Markdown

Another quick note: sorry about missing your submission earlier. due to how our system is set up, if you change the repository name when cloning it, we won’t be able to locate your submission.
I recommend messaging the support team if you ever need to rename your repository in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants