Skip to content

hyprland: 0.36.0 -> 0.37.1, hyprlandPlugins.hy3: 0.36.0 -> 0.36.0-unstable-2024-03-06#296446

Merged
SuperSandro2000 merged 2 commits intoNixOS:masterfrom
fufexan:hyprland
Mar 23, 2024
Merged

hyprland: 0.36.0 -> 0.37.1, hyprlandPlugins.hy3: 0.36.0 -> 0.36.0-unstable-2024-03-06#296446
SuperSandro2000 merged 2 commits intoNixOS:masterfrom
fufexan:hyprland

Conversation

@fufexan
Copy link
Copy Markdown
Contributor

@fufexan fufexan commented Mar 16, 2024

Description of changes

Changelog for 0.37.1
Changelog for 0.37.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@fufexan fufexan mentioned this pull request Mar 16, 2024
Merged
13 tasks
@fufexan fufexan requested a review from wineee March 16, 2024 15:18
@ofborg ofborg Bot requested a review from wozeparrot March 16, 2024 16:06
@ofborg ofborg Bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 16, 2024
@iynaix
Copy link
Copy Markdown
Contributor

iynaix commented Mar 16, 2024

Result of nixpkgs-review pr 296446 run on x86_64-linux 1

1 package failed to build:
  • hyprlandPlugins.hy3
10 packages built:
  • grimblast
  • hdrop
  • hyprland
  • hyprland.dev
  • hyprland.man
  • hyprshot
  • nwg-panel
  • nwg-panel.dist
  • waybar
  • xdg-desktop-portal-hyprland

@wineee
Copy link
Copy Markdown
Member

wineee commented Mar 18, 2024

hy3 need update: outfoxxed/hy3@a392bfd

@fufexan fufexan changed the title hyprland: 0.36.0 -> 0.37.1 hyprland: 0.36.0 -> 0.37.1, hyprlandPlugins.hy3: 0.36.0 -> 0.36.0-unstable-2024-03-06 Mar 18, 2024
@ofborg ofborg Bot requested a review from aacebedo March 18, 2024 11:34
@musjj
Copy link
Copy Markdown
Contributor

musjj commented Mar 19, 2024

Is the ofborg job stuck? It's been running for 19 hours 🤔

@wineee
Copy link
Copy Markdown
Member

wineee commented Mar 19, 2024

hyprland don't work on darwin anyway, tests on linux has passed

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Mar 19, 2024
@aacebedo
Copy link
Copy Markdown
Contributor

aacebedo commented Mar 20, 2024

Can be merged right?

@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Mar 20, 2024
@fufexan
Copy link
Copy Markdown
Contributor Author

fufexan commented Mar 21, 2024

Can be merged right?

Yes.

@aacebedo
Copy link
Copy Markdown
Contributor

aacebedo commented Mar 22, 2024

@SuperSandro2000 can you have a look and merge it please?

@nixos-discourse
Copy link
Copy Markdown

nixos-discourse commented Mar 22, 2024

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3668

AndersonTorres
AndersonTorres suggested changes Mar 22, 2024
View reviewed changes
Comment thread pkgs/applications/window-managers/hyprwm/hyprland/default.nix Outdated
Comment thread pkgs/applications/window-managers/hyprwm/hyprland/default.nix Outdated
Copy link
Copy Markdown
Member

@AndersonTorres AndersonTorres Mar 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this "internal overriding" a good idea?

Copy link
Copy Markdown
Contributor Author

@fufexan fufexan Mar 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might cause rebuilds for people not wanting to use XWayland, but I don't see a simpler way of providing an xwayland-free environment.

Copy link
Copy Markdown
Member

@AndersonTorres AndersonTorres Mar 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hum, understood. That's OK then.

My concern is about passing wlroots as an argument, but in reality using wlroots-with-mods internally.

Copy link
Copy Markdown
Contributor Author

@fufexan fufexan Mar 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can change the argument name to wlroots-hyprland. Same for udis86.

Copy link
Copy Markdown
Member

@AndersonTorres AndersonTorres Mar 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can change the argument name to wlroots-hyprland. Same for udis86.

That's better!

@ofborg ofborg Bot requested a review from aacebedo March 22, 2024 18:48
@wegank wegank removed the 12.approvals: 2 This PR was reviewed and approved by two persons. label Mar 23, 2024
@SuperSandro2000 SuperSandro2000 merged commit b974f5d into NixOS:master Mar 23, 2024
@fufexan fufexan mentioned this pull request Mar 23, 2024
Closed
1 task
This was referenced Mar 27, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wineee wineee wineee approved these changes

@wozeparrot wozeparrot Awaiting requested review from wozeparrot

@aacebedo aacebedo Awaiting requested review from aacebedo

+1 more reviewer

@AndersonTorres AndersonTorres AndersonTorres approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@fufexan @iynaix @wineee @musjj @aacebedo @nixos-discourse @AndersonTorres @SuperSandro2000 @wegank