Conversation
ETeissonniere
left a comment
There was a problem hiding this comment.
Thanks Douglas! I have requested some changes, additionally, shall we remove the graph folder?
| ## Start | ||
|
|
||
| First, install SubQuery CLI globally on your terminal by using NPM `npm install -g @subql/cli` | ||
|
|
||
| You can either clone this GitHub repo, or use the `subql` CLI to bootstrap a clean project in the network of your choosing by running `subql init` and following the prompts. | ||
|
|
||
| Don't forget to install dependencies with `npm install` or `yarn install`! |
There was a problem hiding this comment.
Can you add the SubQL CLI to the devcontainer and remove graph's?
.gitignore
Outdated
| subquery/dist/ | ||
| subquery/.data/ | ||
| subquery/**/types/ | ||
| contracts/ |
There was a problem hiding this comment.
I don't think we need to gitignore this one
subquery/project.ts
Outdated
| }, | ||
| network: { | ||
| chainId: "270", // private network | ||
| endpoint: ["https://rpc-iu435q.nodleprotocol.io"], |
There was a problem hiding this comment.
We are not deployed on the public testnet! Check RPCs here: https://www.notion.so/nodle/ZkSync-Public-Deployments-2c1309f63072424794ad2999bf7ff1c8?pm=c
subquery/project.ts
Outdated
| // Must be a key of assets | ||
| abi: "erc721", | ||
| // This is the contract address for wrapped ether https://explorer.zksync.io/address/0x3355df6D4c9C3035724Fd0e3914dE96A5a83aaf4 | ||
| address: "0xf98633dd7a7af38a3da2c7fc34f1a7a3a14a26b9", |
There was a problem hiding this comment.
Should it be 0xB6844E6dC9C4E090b73c1a91e8648A3F81eD434a?
There was a problem hiding this comment.
Once merged will update the values. This is currently pointing to the private ContentSign contract
Just done
subquery/project.ts
Outdated
| options: { | ||
| // Must be a key of assets | ||
| abi: "AccessControl", | ||
| // This is the contract address for wrapped ether https://explorer.zksync.io/address/0x3355df6D4c9C3035724Fd0e3914dE96A5a83aaf4 | ||
| address: "0x27d45764490b8C4135d1EC70130163791BDE6db5", | ||
| }, |
There was a problem hiding this comment.
AccessControl was deprecated to the profit of the WhitelistPaymaster built in's whitelist. Can we adjust this?
There was a problem hiding this comment.
Great, @ETeissonniere could we store the ABI's somewhere?
Also, this means is not required to index every user role, thus removing this mapping from the code is Ok?
Saw AccessControl is used but only for admin roles 👍
There was a problem hiding this comment.
I think it is fine to remove for now!
There was a problem hiding this comment.
ABI wise... would a github release work for you?
Co-authored-by: Eliott Teissonniere <[email protected]>
Port previous graph indexing schemas to subquery