Skip to content
This repository was archived by the owner on Jun 18, 2024. It is now read-only.

Need to be able to set alternate reply address.#133

Closed
erlingm wants to merge 9 commits intoOfficeDev:masterfrom
erlingm:master
Closed

Need to be able to set alternate reply address.#133
erlingm wants to merge 9 commits intoOfficeDev:masterfrom
erlingm:master

Conversation

@erlingm
Copy link
Copy Markdown

@erlingm erlingm commented Dec 1, 2014

There seems to be no replacement for the old public void setReplyTo(EmailAddress replyTo) method.
(It was present in the API before the initial commit to GitHub.)

@azurecla
Copy link
Copy Markdown

azurecla commented Dec 1, 2014

Hi @erlingm, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no contribution license agreement is required at this point. Real humans will now evaluate your PR.

TTYL, AZPRBOT;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe there should be added some javadoc?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should take in an email address collection to enable reply to multiple addresses. This will also match the getReplyTo() method.

@vboctor
Copy link
Copy Markdown
Contributor

vboctor commented Dec 3, 2014

Looks good.

  • It would be great if you can add unit tests for set/getReplyTo().
  • Please also open an issue and associate it with this pull request.

Conflicts:
	src/main/java/microsoft/exchange/webservices/data/EmailMessage.java
…, but still be source compatible with the old call from the earlier version of the API.

Added unit-tests for the method.
…ddresses, but still be source compatible with the old call from the earlier version of the API."

This reverts commit 595a293.
@erlingm
Copy link
Copy Markdown
Author

erlingm commented Dec 19, 2014

I have realized that someone has decided to change how this API should be used, leaving my suggested change unnecessary at best, or even undesired.
I therefore withdraw my changes.

@erlingm erlingm closed this Dec 19, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants