This repository was archived by the owner on Jun 18, 2024. It is now read-only.
Remove unused methods from ServiceRequestBase#27
Merged
vboctor merged 2 commits intoOfficeDev:masterfrom Sep 22, 2014
Merged
Conversation
- ServiceRequestBase.emit() is unused. - ServiceRequestBase.endGetEwsHttpWebResponse() is unused, but also incorrect: Why would one compare an HTTP status code with an enum ordinal?!
Merged
Contributor
There was a problem hiding this comment.
There seems to be a commented call to this method in SimpleServiceRequestBase(). Please revise to match.
Contributor
Author
There was a problem hiding this comment.
I added a commit which removes the commented call.
Also removed a getter call without assignment and some other commented code in SimpleServiceRequestBase that made no sense.
vboctor
added a commit
that referenced
this pull request
Sep 22, 2014
Remove unused methods from ServiceRequestBase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ServiceRequestBase.emit()is unused.ServiceRequestBase.endGetEwsHttpWebResponse()is unused, but also incorrect: Why would one compare an HTTP status code with an enum ordinal?!