Merged
Conversation
When I was playing around with the third-party cookie settings in Firefox, it looked like live.com was set as an exception by default, so I decided to take it out of the original error message about cookies being disabled. But, it seems that cookies are only allowed on the sign in endpoint. For whatever reason, if you don't have the live.com domain added as an exception, you are unable to sign out of the clipper. So, I've added back in the need to add live.com to the list of exceptions.
When I was doing the cleanup for the third-party cookie message, it looks like I accidentally left the error description in both places.
In order to know if we should show the error description when sign in errors occur, we were counting on the updateReason property being set on the returning object. This was true until my last change, where we always return a valid UserInfo (except in this one case). After my change, the updateReason property was getting blown away and because of that, the logic around when to show the error message could never be true.
Contributor
|
After cleaning up the |
Should have done this at the beginning. The previous version is a little too hard to read.
Contributor
|
LGTM |
Contributor
|
Looks good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #296
The details in each commit describe the fixes more completely, but in general, the O365 errors were not being shown because the updateReason property was not being set in the returning error object. Because of this, the logic around when to show the message to the user was broken.
I also made a related UI fix and updated the string to include the live.com domain as a needed exception.