Skip to content

Fix the PDF rendering quality #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leakymemory merged 1 commit into from
May 17, 2017
Merged

Fix the PDF rendering quality #371

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/scripts/contentCapture/pdfJsDocument.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,13 @@ export class PdfJsDocument implements PdfDocument {
return new Promise<string>((resolve) => {
// In pdf.js, indexes start at 1
this.pdf.getPage(pageIndex + 1).then((page) => {
let viewport = page.getViewport(1 /* scale */);
// Issue #369: When the scale is set to 1, we end up with poor quality images
// on high resolution machines. The best explanation I found for this was in
// this article: http://stackoverflow.com/questions/35400722/pdf-image-quality-is-bad-using-pdf-js
// Note that we played around with setting the scale from 3-5, which looked better on high
// resolution monitors - but did not look good at all at lower resolutions. scale=2 seems
// to be the happy medium.
let viewport = page.getViewport(2 /* scale */);
let canvas = document.createElement("canvas") as HTMLCanvasElement;
let context = canvas.getContext("2d");
canvas.height = viewport.height;
Expand Down